| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: moving some code out of explain.c |
| Date: | 2025-02-27 20:05:54 |
| Message-ID: | 2612294.1740686754@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> The thing that was bugging me a bit is that explain_format.h includes
> explain.h.
Yeah, I did not like that at all either -- it makes things a bit
circular, and I fear IWYU is going to make stupid recommendations
like not including explain.h in explain.c.
Did you look at avoiding that with our standard trick of writing
detail-free struct declarations? That is, explain_format.h
would need
struct ExplainState; /* avoid including explain.h here */
and then s/ExplainState/struct ExplainState/ in all the function
declarations. You'd still need to get List from someplace, but
it could be gotten by including primnodes.h or even pg_list.h.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-02-27 20:40:57 | Re: SQLFunctionCache and generic plans |
| Previous Message | Pavel Stehule | 2025-02-27 20:01:50 | Re: SQLFunctionCache and generic plans |