Re: BUG #13471: Reload with include_dir results in incorrect "contains errors" message

andomar(at)aule(dot)net writes:
> 1. Create a new Postgres installation with "pg_ctl init"
> 2. In postgresql.conf, remove the comment before "include_dir = 'conf.d'"
> 3. Create a file "conf.d/extra.conf" containing "max_connections = 123"
> 4. Start Postgres with "pg_ctl start"
> 5. Reload Postgres with "pg_ctl reload"
> 6. Read the log file in pg_log; it says:
> received SIGHUP, reloading configuration files
> parameter "max_connections" cannot be changed without restarting the
> server
> configuration file "/home/wessel/test/postgresql.conf" contains errors;
> unaffected changes were applied

> But max_connections was not changed after restarting the server. These
> messages are incorrect.

Although I was correct in remembering that this had been fixed in 9.4,
it turns out it got broken again in 9.4.1 (by me :-(). I've committed
a fix that will appear in 9.4.5.

regards, tom lane