Re: pgAgent: C++ Port - Patch Review

Hi Dave,

- The new code doesn't match the existing coding style - you've used 4
spaces instead of tabs for indents, and braces to open a new context
are not on a new line for example. Please follow the existing coding
style to make the diffs (much) easier to read. You might also try
something like: astyle -n -p -b -S -t4 -k3 -z2 `find . -name "*.cpp"
-o -name "*.h"`

=> done with astyle

- There are numerous comments that are clearly notes to yourself, and
lines of code that have been commented out. This needs to be cleaned
up before anything can be committed.

=> cleaned up

- There are no updates to the build system, which seems essential for
this patch. As a result, I can't compile the code at all yet.

=> done. wx settings are out and sdtc++ are in.
=> cmake and make running without warnings or errors
=> My Plattform:
64-Bit Linux 3.7.10-1.16
openSuse Distro
gcc 4.7.2 with std=c++11

- You seem to have hard-coded the exit code from Windows batch job
steps to 1. Why?

=> i changed back to git-head version. i believe it come from old 3.3.0 source code
version. I will never make such things.

- You also seem to have removed the connection pool. Why?

Why not?
Pos:
+ The code is simpler (no locking at all, fewer code)
+ easier maintenance

Neg:
- i'm not sure. maybe more parallel connection.

There are two scenarios:
normal typ: two or three dozen job. only a few running in parallel

big typ: many many jobs. many running in parallel. This companies have other
problems or use a connection pooler like pgpool.

In summary the positive points weigh more heavily

Thomas