Re: Regression tests fails to start on system without unix sockets.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Kurt Roeckx <Q(at)ping(dot)be>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Regression tests fails to start on system without unix sockets.
Date: 2003-06-21 16:20:35
Message-ID: 26075.1056212435@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Kurt Roeckx <Q(at)ping(dot)be> writes:
> The regression tests will fail to start on a system that doesn't
> have, or wasn't compiled for, unix domain sockets.
> I see some options to fix this:
> - Always start with -i
> - Make the "unix_sockets" variable depend on
> HAVE_UNIX_SOCKETS intead of listen the OSs.

The second way is the way it should have been done all along.

Probably the best fix is to add a command-line switch to pg_regress
to instruct it to use -i, and then have the makefile test
HAVE_UNIX_SOCKETS to decide whether to pass that switch. This way,
hand invocation of the script could easily run the test both ways,
on machines where that's possible.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2003-06-21 16:23:42 Re: Two weeks to feature freeze
Previous Message Larry Rosenman 2003-06-21 15:48:19 Re: Two weeks to feature freeze