Re: checksum_impl.h fails cpluspluscheck

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: checksum_impl.h fails cpluspluscheck
Date: 2013-06-30 04:03:59
Message-ID: 26025.1372565039@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> ./src/include/storage/checksum_impl.h: In function uint32 pg_checksum_block(char*, uint32):
> ./src/include/storage/checksum_impl.h:154: warning: comparison between signed and unsigned integer expressions

> We could exclude that file from the check, but it's also easy to fix by
> making the variables unsigned:
> ...
> Preferences?

Possibly use uint32 for consistency with the other vars in the function?
No real objection to unsigned int, though, since it's the same thing in
practice.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2013-06-30 04:44:04 Re: checksum_impl.h fails cpluspluscheck
Previous Message Peter Eisentraut 2013-06-30 03:55:51 checksum_impl.h fails cpluspluscheck