From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, Paul Ramsey <pramsey(at)cleverelephant(dot)ca>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Pg18 Recursive Crash |
Date: | 2024-12-18 02:28:57 |
Message-ID: | 2602360.1734488937@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Wed, 18 Dec 2024 at 14:02, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> it appears your patch did not fully adjust BuildTupleHashTableExt
>> for variable input-slot type. You need the attached as well.
> Do you have a test case in master that triggers a problem here?
No, that's what I didn't want to spend time looking for ;-).
But here is a WIP modification of my 0001 patch from the SetOp
improvement thread -- the difference is to lobotomize
setop_load_hash_tuple to just return the input slot. Without
the execGrouping.c changes, it gets assertion failures in the core
regression tests. (My intention had been to remove
setop_load_hash_tuple and then adjust build_hash_table to
pass a non-null inputOps if the two inputs have the same tuple
slot type. But I got stuck on this step.)
regards, tom lane
Attachment | Content-Type | Size |
---|---|---|
wip-setop-improvements.patch | text/x-diff | 67.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Smith | 2024-12-18 02:41:57 | Re: Logical Replication of sequences |
Previous Message | Kohei Harikae (Fujitsu) | 2024-12-18 02:05:20 | RE: Windows meson build |