No parameter values checking while creating Alter subscription...Connection

From: tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: No parameter values checking while creating Alter subscription...Connection
Date: 2017-05-25 13:43:46
Message-ID: 25e980e2-40a6-a8f7-6908-d9ab5b72eb05@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

We usually check connection parameter values while creating create
subscription

\\port is WRONG

postgres=# create subscription c1 connection 'port=4000 ' publication pub;
ERROR: could not connect to the publisher: could not connect to server:
No such file or directory
Is the server running locally and accepting
connections on Unix domain socket "/tmp/.s.PGSQL.4000"?
postgres=#

\\when database doesn't exist

postgres=# create subscription c1 connection 'dbname=postgre '
publication pub;
ERROR: could not connect to the publisher: FATAL: database "postgre"
does not exist
postgres=#

but such checking is not done at the time of alter subscription ..
connection

postgres=# alter subscription c1 connection 'port=4000';
ALTER SUBSCRIPTION
postgres=# alter subscription c1 connection 'dbname=cc';
ALTER SUBSCRIPTION

--
regards,tushar
EnterpriseDB https://www.enterprisedb.com/
The Enterprise PostgreSQL Company

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-05-25 13:55:09 Re: pg_dump ignoring information_schema tables which used in Create Publication.
Previous Message Sokolov Yura 2017-05-25 13:39:22 Re: Fix performance of generic atomics