From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Jeff Davis <jdavis(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Transfer statistics during pg_upgrade. |
Date: | 2025-02-21 14:51:12 |
Message-ID: | 25d26774-25fa-46f2-9888-c6a707d1fef7@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On 2025-02-20 Th 4:29 AM, Jeff Davis wrote:
> Transfer statistics during pg_upgrade.
Small nit.
I notice this commit has introduced a couple of dubious uses of
"mututally exclusive":
doc/src/sgml/ref/pg_dump.sgml: This option is mutually exclusive
to <option>--data-only</option>
doc/src/sgml/ref/pg_dump.sgml- and
<option>--statistics-only</option>.
--
doc/src/sgml/ref/pg_restore.sgml: This option is mutually
exclusive of <option>--data-only</option>
doc/src/sgml/ref/pg_restore.sgml- and
<option>--statistics-only</option>.
I don't think this is idiomatic usage, and it's possibly not correct
usage. At best it is jarring. One does not normally follow "mutually
exclusive" with a preposition. I would replace the these with something
like "This option cannot be used with ...". If you want to use the
phrase, it should be something like "This option and ... are mutually
exclusive."
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2025-02-21 16:48:31 | pgsql: Make test portlock logic work with meson |
Previous Message | Michael Paquier | 2025-02-21 11:38:16 | pgsql: Fix cross-version upgrades with XMLSERIALIZE(NO INDENT) |