Re: links to 12 release notes broken after branching

From: "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-www(at)postgresql(dot)org
Subject: Re: links to 12 release notes broken after branching
Date: 2019-10-30 23:42:58
Message-ID: 25d0432e-3e20-d21b-638f-af80cc55ad5f@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

On 10/30/19 7:37 PM, Andres Freund wrote:
> Hi,
>
> On 2019-10-30 19:06:49 -0400, Jonathan S. Katz wrote:
>> If no objections, I can apply soon.
>
> Cool.
>
>
>> diff --git a/pgweb/docs/views.py b/pgweb/docs/views.py
>> index 1480903c..daea801e 100644
>> --- a/pgweb/docs/views.py
>> +++ b/pgweb/docs/views.py
>> @@ -80,7 +80,7 @@ def docpage(request, version, filename):
>> # a) viewing the docs for a version that does not exist yet (e.g. active
>> # development before an initial beta) OR
>> # b) viewing the docs for a beta version
>> - is_released = Version.objects.filter(tree=release_version, testing=0).exists() if version == "devel" else True
>> + is_released = Version.objects.filter(tree=release_version).exists() if version == "devel" else True
>> # If we are viewing a released version of the release notesand the
>> # release versions do not match, then we redirect
>> if is_released and release_version != ver:
>
> I'd probably still rename is_released, given that it's only released at
> a beta at that point :)

I prefer green paint on my walls ;)

Looking over the code, I need to update the comment around it anyway, so
I'll call it "is_branched", tidy up the comments, and push.

Links should be live again ~10 mins from this email.

Jonathan

In response to

Browse pgsql-www by date

  From Date Subject
Next Message Peter Geoghegan 2019-11-01 00:08:33 Proprietary software marketing on Wiki page -- AgensGraph Postgres fork
Previous Message Andres Freund 2019-10-30 23:37:41 Re: links to 12 release notes broken after branching