| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Antonin Houska <ah(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PoC] Federated Authn/z with OAUTHBEARER |
| Date: | 2025-02-12 14:59:11 |
| Message-ID: | 25b978e4-6be9-4c83-989b-574e5e79b276@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08.02.25 02:56, Jacob Champion wrote:
>> + oauth_json_set_error(ctx, /* don't bother translating */
>> With the project style format for translator comments this should be:
>>
>> + /* translator: xxx */
>> + oauth_json_set_error(ctx,
> This comment was just meant to draw attention to the lack of
> libpq_gettext(). Does it still need a translator note if we don't run
> it through translation?
No, that wouldn't have any effect.
I think you can just remove that comment. It's pretty established that
internal errors don't need translation, so it would be understood from
looking at the code.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-02-12 15:23:36 | Re: SQL:2011 application time |
| Previous Message | Matthias van de Meent | 2025-02-12 14:59:08 | Re: Parallel CREATE INDEX for GIN indexes |