| From: | "Imseih (AWS), Sami" <simseih(at)amazon(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: allow changing autovacuum_max_workers without restarting |
| Date: | 2024-04-14 01:56:09 |
| Message-ID: | 25FBADC0-52E7-4DE6-B043-68E5F77D4CB1@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> IIRC using GUC hooks to handle dependencies like this is generally frowned
> upon because it tends to not work very well [0]. We could probably get it
> to work for this particular case, but IMHO we should still try to avoid
> this approach.
Thanks for pointing this out. I agree, this could lead to false logs being
emitted.
> so it might not be crucial to emit a
> WARNING here.
As mentioned earlier in the thread, we can let the autovacuum launcher emit the
log, but it will need to be careful not flood the logs when this condition exists ( i.e.
log only the first time the condition is detected or log every once in a while )
The additional complexity is not worth it.
Regards,
Sami
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Wen Yi | 2024-04-14 02:02:00 | Re: Things I don't like about \du's "Attributes" column |
| Previous Message | Tom Lane | 2024-04-14 00:09:11 | Re: In MacOS, psql reacts on SIGINT in a strange fashion (Linux is fine) |