Re: Small patch modifying variable name to reflect the logic involved

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Krishnakumar R <kksrcv001(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small patch modifying variable name to reflect the logic involved
Date: 2023-09-15 17:50:51
Message-ID: 25C2B047-66B4-4291-A26B-B42359D91A5C@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 14 Sep 2023, at 11:30, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> On 14 Sep 2023, at 08:28, Krishnakumar R <kksrcv001(at)gmail(dot)com> wrote:
>
>> Please find a small patch to improve code readability by modifying
>> variable name to reflect the logic involved - finding diff between end
>> and start time of WAL sync.
>
> - INSTR_TIME_ACCUM_DIFF(PendingWalStats.wal_sync_time, duration, start);
> + INSTR_TIME_SET_CURRENT(end);
> + INSTR_TIME_ACCUM_DIFF(PendingWalStats.wal_sync_time, end, start);
>
> Agreed, the duration is the result of the INSTR_TIME_ACCUM_DIFF calculation,
> not what's stored in the instr_time variable.

And done, with a small fixup to handle another occurrence in the same file.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Yurii Rashkovskii 2023-09-15 18:26:16 SET ROLE documentation improvement
Previous Message Nathan Bossart 2023-09-15 16:35:38 Re: Add 'worker_type' to pg_stat_subscription