| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | Vaishnavi Prabakaran <vaishnaviprabakaran(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: check with serial |
| Date: | 2017-05-03 14:12:06 |
| Message-ID: | 25997.1493820726@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> On 05/02/2017 10:13 PM, Vaishnavi Prabakaran wrote:
>> And, now after your patch, do we still need "installcheck-parallel"
>> command? It is redundant IMO, just give a thought.
> I'd be quite happy to remove the target in favor of this more general
> solution.
-1 --- that will break a lot of existing habits to no purpose, not to
mention creating complications for scripts used to test multiple branches.
We have intentionally maintained backwards compatibility in these testing
targets for a very long time, even though that's left us with
inconsistencies like installcheck defaulting to serial while check
defaults to parallel. Adding a new capability is not an excuse for
breaking the historical test targets.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Banck | 2017-05-03 14:18:36 | Re: [PostgreSQL 10] default of hot_standby should be "on"? |
| Previous Message | Andrew Dunstan | 2017-05-03 14:00:29 | Re: check with serial |