| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Claudio Freire <klaussfreire(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: pg_upgrade and materialized views |
| Date: | 2018-02-20 22:05:29 |
| Message-ID: | 25875.1519164329@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Andres Freund <andres(at)anarazel(dot)de> writes:
> The important part then happens in pg_dump. Note
> if (dopt->binary_upgrade &&
> (tbinfo->relkind == RELKIND_RELATION ||
> tbinfo->relkind == RELKIND_FOREIGN_TABLE ||
> tbinfo->relkind == RELKIND_PARTITIONED_TABLE))
> note that the above if clause doesn't include materialized tables. Which
> sems to explain this bug? Could you check that just updating the above
> if to include matviews fixes the bug for you?
I'm also wondering why it *does* include foreign tables. Surely
relfrozenxid is meaningless for a FT?
> Looking into this I also saw:
> set_frozenxids(bool minmxid_only)
> which makes a bit uncomfortable, but I can't quite put my finger on
> why.
The fact that it's inconsistent with the other list is surely a red flag,
eg seems like we should include RELKIND_PARTITIONED_TABLE there too.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-02-20 22:08:01 | Re: pg_upgrade and materialized views |
| Previous Message | Claudio Freire | 2018-02-20 22:05:12 | Re: pg_upgrade and materialized views |