| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Marko Kreen <marko(at)l-t(dot)ee> |
| Cc: | Michael Fuhr <mike(at)fuhr(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pgcrypto 3des failure, OpenSSL 0.9.8, Solaris 9/sparc |
| Date: | 2005-07-05 18:55:07 |
| Message-ID: | 25839.1120589707@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Marko Kreen <marko(at)l-t(dot)ee> writes:
> I see 2 variants:
> 1) put @with_openssl@ and @with_zlib@ variables into
> contrib/pgcrypto/Makefile.in and let configure process it.
> 2) put them in some other makefile fragment under src/
> and let pgcrypto include it.
> First I did the simple thing and put them into Makefile.global.in,
> but this does not work, as it needs to be included _after_ all
> module variables are set. So 2) needs a new file.
Hm ... libpq manages to build code that requires openssl without
needing a generated Makefile, so why do we need it here?
I'd prefer #1 of these two, but seeing that no other contrib module
has a Makefile.in, not having to do either would be even better.
This is particularly true if you aren't going to completely eliminate
the hand-configuration options in the Makefile, because having to edit
a generated Makefile or having to edit Makefile.in and then remember
to reconfigure both suck.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marko Kreen | 2005-07-05 19:32:21 | Re: pgcrypto 3des failure, OpenSSL 0.9.8, Solaris 9/sparc |
| Previous Message | Marko Kreen | 2005-07-05 18:43:47 | Re: pgcrypto 3des failure, OpenSSL 0.9.8, Solaris 9/sparc |