| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>, PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: <IDLE> and waiting |
| Date: | 2008-02-02 23:39:39 |
| Message-ID: | 25828.1201995579@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Gurjeet Singh escribi:
>> I just looked at the patch... Isn't PG_TRY() an expensive call to make in
>> the lock.c code? I was thinking of registering a Xact callback using
>> RegisterXactCallback() and performing 'waiting' reset in that callback if
>> the Xact event is XACT_EVENT_ABORT.
> PG_TRY is not expensive as all that -- it's just a sigsetjmp() call and
> another stack frame.
Also, since we're about to block here, shaving microseconds is not all
that important.
The reason I did it that way was to avoid having to export the saved
ps-display string out to someplace LockWaitCancel could find it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gurjeet Singh | 2008-02-03 05:05:46 | Wrong query examples in docs |
| Previous Message | Gurjeet Singh | 2008-02-02 23:33:58 | Re: <IDLE> and waiting |