Re: relfilenode

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: relfilenode
Date: 2005-10-28 02:03:42
Message-ID: 25827.1130465022@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> The docs have this description for pg_class::relfilenode: "Name of the
> on-disk file of this relation; 0 if none". However, Elein just pointed
> out to me that there are no entries with 0, so this description seems
> incorrect. What should we say? It appears that in at least some of these
> cases the value is the same as the oid.

My opinion is that the documentation is right and the code is wrong ;-)
It's a bad idea to have valid-looking relfilenodes in entries that are
not describing real on-disk structures --- not least because such values
could by chance match on-disk files that actually exist, but belong to a
different pg_class entry.

This is probably just a matter of laziness somewhere in heap.c.

regards, tom lane

In response to

  • relfilenode at 2005-10-28 01:12:15 from Andrew Dunstan

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim C. Nasby 2005-10-28 02:14:15 Re: enums
Previous Message Trent Shipley 2005-10-28 01:58:21 Re: enums