| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, obouda(at)email(dot)cz, Pg Bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: Wrong aggregate result when sorting by a NULL value |
| Date: | 2018-11-05 00:15:47 |
| Message-ID: | 25772.1541376947@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2018-11-04 18:49:40 -0500, Tom Lane wrote:
>> Meh. I'm unexcited about getting rid of one type of compiler warning by
>> introducing another one.
> It's impracticable to enable dead code warnings in postgres
> anyway. There's way way too many of them (all the returns after
> elog(ERROR) etc are enough to make it infeasible to change that).
I think you have a very limited conception of what sorts of warnings
code like that would trigger. In particular, even given the
unsubstantiated assumption that nobody's compiler would complain,
I think static analyzers like Coverity might.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-11-05 02:09:21 | Re: BUG #15437: Segfault during insert into declarative partitioned table with a trigger creating partition |
| Previous Message | Andres Freund | 2018-11-05 00:09:00 | Re: Wrong aggregate result when sorting by a NULL value |