Re: ADD COLUMN with PRIMARY KEY bug (was: I think this is a BUG?)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Brendan Jurd" <direvus(at)gmail(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org, "Richard Huxton" <dev(at)archonet(dot)com>, kaloyan(at)digsys(dot)bg
Subject: Re: ADD COLUMN with PRIMARY KEY bug (was: I think this is a BUG?)
Date: 2008-04-24 19:13:42
Message-ID: 2574.1209064422@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

"Brendan Jurd" <direvus(at)gmail(dot)com> writes:
> I realised that there's no reason for preparing a separate SetNotNull
> subcommand anymore, now that ATExecAddColumn takes care of enforcing
> the constraint, so I removed this special case.

This part seems to me to be code beautification, not a bug-fix, and
shouldn't be back-patched (particularly in view of the fact that we
haven't tested the change all that much --- there might be other
places depending on the old behavior).

Will take care of this.

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2008-04-24 19:17:31 Re: BUG #4128: The postmaster.opts.default file is begin ignored
Previous Message Brendan Jurd 2008-04-24 19:07:18 ADD COLUMN with PRIMARY KEY bug (was: I think this is a BUG?)