From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Gregory Stark <stark(at)enterprisedb(dot)com>, Christopher Browne <cbbrowne(at)gmail(dot)com>, Dave Page <dpage(at)pgadmin(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Recovery Test Framework |
Date: | 2009-01-13 14:53:09 |
Message-ID: | 25708.1231858389@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> Robert Haas wrote:
>> (It would be interesting to here how much value people think it has
>> added, and get suggestions on how to do things better next time.)
> I'm not sure how much round-robin-review has taken load off committers,
> you have to read and understand a patch before committing anyway. It has
> helped, for sure, but not dramatically. However, I think that it has
> made a big difference from authors point of view; you get feedback earlier.
I think it's helped from the committers' standpoint too, in the form of
taking care of some issues that would otherwise have had to be dealt
with by the committer. (Which was all we asked for anyway.)
In my mind though, the real benefit of the system and the reason we
should keep it up is to get more people looking at the code. New
committers don't grow on trees, they come from people getting involved.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2009-01-13 14:56:02 | Re: Open item: kerberos warning message |
Previous Message | Stephen Frost | 2009-01-13 14:21:21 | Re: New patch for Column-level privileges |