| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Jakub Glapa <jakub(dot)glapa(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Fabio Isabettini <fisabettini(at)voipfuture(dot)com>, Arne Roland <A(dot)Roland(at)index(dot)de>, Sand Stone <sand(dot)m(dot)stone(at)gmail(dot)com>, Rick Otten <rottenwindfish(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: dsa_allocate() faliure |
| Date: | 2019-02-11 01:22:45 |
| Message-ID: | 25697.1549848165@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-performance |
Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> On Mon, Feb 11, 2019 at 10:33 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I observe from
>> https://coverage.postgresql.org/src/backend/utils/mmgr/freepage.c.gcov.html
>> that the edge cases in this function aren't too well exercised by
>> our regression tests, meaning that the buildfarm might not prove
>> much either way about the correctness of this patch. That is one
>> factor pushing me to think we shouldn't risk it. But, taking a
>> longer view, is that something that's practical to improve?
> Yeah. This is a nice example of code that really deserves unit tests
> written in C. Could be good motivation to built the infrastructure I
> mentioned here:
> https://www.postgresql.org/message-id/flat/CAEepm%3D2heu%2B5zwB65jWap3XY-UP6PpJZiKLQRSV2UQH9BmVRXQ%40mail.gmail.com
Meh. I think if you hold out for that, you're going to be waiting a
long time. I was thinking more along the lines of making a test API
in src/test/modules/, akin to what we've got for predtest or rbtree.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2019-02-11 01:35:04 | Re: indxpath.c's references to IndexOptInfo.ncolumns are all wrong, no? |
| Previous Message | Tom Lane | 2019-02-11 01:18:48 | indxpath.c's references to IndexOptInfo.ncolumns are all wrong, no? |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | keith anderson | 2019-02-11 08:05:50 | Re: Partitioning Optimizer Questions and Issues |
| Previous Message | Thomas Munro | 2019-02-11 00:24:38 | Re: dsa_allocate() faliure |