From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Greg Stark <stark(at)mit(dot)edu> |
Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Remove trailing newlines from pg_upgrade's messages |
Date: | 2022-06-20 18:57:08 |
Message-ID: | 2567656.1655751428@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Greg Stark <stark(at)mit(dot)edu> writes:
> On Wed, 15 Jun 2022 at 11:54, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Yeah, that is sort of the inverse problem. I think those are there
>> to ensure that the text appears on a fresh line even if the current
>> line has transient status on it. We could get rid of those perhaps
>> if we teach pg_log_v to remember whether it ended the last output
>> with a newline or not, and then put out a leading newline only if
>> necessary, rather than hard-wiring one into the message texts.
> Is the problem that pg_upgrade doesn't know what the utilities it's
> calling are outputting to the same terminal?
Hmmm ... that's a point I'd not considered, but I think it's not an
issue here. The subprograms generally have their output redirected
to their own log files.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2022-06-20 23:58:38 | Re: CFM for 2022-07 |
Previous Message | Greg Stark | 2022-06-20 18:29:25 | Re: Remove trailing newlines from pg_upgrade's messages |