Re: BUG #18340: BitString may break nodetoString() conversion for a raw parse tree

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: exclusion(at)gmail(dot)com
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #18340: BitString may break nodetoString() conversion for a raw parse tree
Date: 2024-02-13 15:34:32
Message-ID: 2565845.1707838472@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

PG Bug reporting form <noreply(at)postgresql(dot)org> writes:
> When a server compiled with -DWRITE_READ_PARSE_PLAN_TREES, the following
> query:
> SELECT x' 0';
> produces:
> ERROR: did not find '}' at end of input node

> Observed starting from commit 40ad8f9de, which implemented
> WRITE_READ_PARSE_PLAN_TREES for raw parse trees.

Bleah. That's presumably my fault, will take a look.

> More interesting results may be obtained (e.g.,
> WARNING: outfuncs/readfuncs failed to produce an equal raw parse tree
> ), but with raw trees only, not with node trees stored in the database,
> considering core code.
> Still codesearch.debian.net shows that nodeToString() used by several
> extensions: pg_qual_stats, pgpool2, hypopg, pglogical; perhaps some of
> them use that conversion unsafely (without processing a node with
> transformExpr() or so).

I doubt there's any reason to consider this a critical problem
right now. We should fix it of course, in the expectation that
we might need it to work someday.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2024-02-13 17:32:26 BUG #18341: SIGBUS with > 4GB DSM and 'dynamic_shared_memory_type = mmap'
Previous Message Heikki Linnakangas 2024-02-13 14:23:20 Re: DSA_ALLOC_NO_OOM doesn't work