| From: | Shinya Kato <Shinya11(dot)Kato(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Emit a warning if the extension's GUC is set incorrectly |
| Date: | 2021-11-15 01:03:22 |
| Message-ID: | 25643eaa81a69416317e85c2fd7d4c0a@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-11-15 04:50, Daniel Gustafsson wrote:
> Seems reasonable on a quick skim, commit da2c1b8a2 did a similar
> roundup back
> in 2009 but at the time most of these didn't exist (pg_trgm did but
> didn't have
> custom option back then). There is one additional callsite defining
> custom
> variables in src/pl/tcl/pltcl.c which probably should get this
> treatment as
> well, it would align it with the pl/perl counterpart.
>
> I'll have a closer look and test tomorrow.
Thank you for the review!
I have missed src/pl/tcl/pltcl.c, so I created the new patch.
--
Regards,
--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| Attachment | Content-Type | Size |
|---|---|---|
| v2_Add_EmitWarningOnPlaceholderes.patch | text/x-diff | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2021-11-15 01:37:36 | Re: Skipping logical replication transactions on subscriber side |
| Previous Message | Peter Smith | 2021-11-15 01:01:37 | Re: row filtering for logical replication |