| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Fujii Masao" <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | "Robert Lor" <Robert(dot)Lor(at)sun(dot)com>, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Bruce Momjian" <bruce(at)momjian(dot)us>, "pgsql-hackers list" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: DTrace probes patch |
| Date: | 2008-12-18 14:34:22 |
| Message-ID: | 25553.1229610862@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Fujii Masao" <masao(dot)fujii(at)gmail(dot)com> writes:
> On Thu, Dec 18, 2008 at 4:49 AM, Robert Lor <Robert(dot)Lor(at)sun(dot)com> wrote:
>> My understanding is that we only want to track the XLogWrite when advancing
>> to the next buffer page, and if there is unwritten data in the new buffer
>> page, that indicates no more empty WAL buffer pages available, but I may be
>> wrong. I did some tests by adjusting wal_buffers, and I could observe this
>> behavior, more calls to XLogWrite with smaller wal_buffers.
> I understood your intention. But, I think that its function name is somewhat
> confusing.
I agree. If the probe is meant to track only *some* WAL writes
then it needs to be named something less generic than
TRACE_POSTGRESQL_WAL_BUFFER_WRITE.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-12-18 14:36:18 | Re: Function with defval returns error |
| Previous Message | Emmanuel Cecchet | 2008-12-18 13:41:04 | Re: Partitioning wiki page |