Re: pgsql: Add basic JSON_TABLE() functionality

Op 4/4/24 om 13:21 schreef Amit Langote:
> Add basic JSON_TABLE() functionality
>

Great that it's now committed. Congrats!

There is one 'uninitialized' muttering during compile (gcc 13.2.0):

In function ‘transformJsonFuncExpr’,
inlined from ‘transformExprRecurse’ at parse_expr.c:373:13:
parse_expr.c:4317:34: warning: ‘default_format’ may be used
uninitialized [-Wmaybe-uninitialized]
4317 | jsexpr->formatted_expr = transformJsonValueExpr(pstate,
func_name,
|
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4318 |
func->context_item,
|
~~~~~~~~~~~~~~~~~~~
4319 |
default_format,
|
~~~~~~~~~~~~~~~
4320 |
JSONBOID,
|
~~~~~~~~~
4321 |
false);
|
~~~~~~
parse_expr.c: In function ‘transformExprRecurse’:
parse_expr.c:4257:24: note: ‘default_format’ was declared here
4257 | JsonFormatType default_format;
| ^~~~~~~~~~~~~~

Thanks!

Erik