From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Alex Williams <valenceshell(at)protonmail(dot)com>, "pgsql-sql(at)postgresql(dot)org" <pgsql-sql(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pg_dump compatibility level / use create view instead of create table/rule |
Date: | 2019-10-26 21:18:09 |
Message-ID: | 25499.1572124689@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-sql |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2019-10-10 11:20:14 -0400, Tom Lane wrote:
>> The reason we get "REPLICA IDENTITY NOTHING" is that a view's relreplident
>> is set to 'n' not 'd', which might not have been a great choice.
> Hm, yea. I wonder if we should add a REPLICA_IDENTITY_INVALID or such,
> for non relation relkinds? I'm mildly inclined to think that setting it
> to REPLICA_IDENTITY_DEFAULT is at least as confusing as
> REPLICA_IDENTITY_DEFAULT...
Yeah, I'd be for that in HEAD probably. But of course we can't change
the 9.x branches like that.
>> This is fixed in v10 and up thanks to d8c05aff5. I was hesitant to
>> back-patch that at the time, but now that it's survived in the field
>> for a couple years, I think a good case could be made for doing so.
> +1
Just finishing up the back-patch now.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Vik Fearing | 2019-10-26 23:09:29 | Re: Proposition to use '==' as synonym for 'IS NOT DISTINCT FROM' |
Previous Message | Tom Lane | 2019-10-26 21:16:37 | Re: Proposition to use '==' as synonym for 'IS NOT DISTINCT FROM' |
From | Date | Subject | |
---|---|---|---|
Next Message | JORGE MALDONADO | 2019-11-07 00:42:15 | Using transactions in all CRUD operations |
Previous Message | Andres Freund | 2019-10-26 20:56:30 | Re: pg_dump compatibility level / use create view instead of create table/rule |