| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, Paul Ramsey <pramsey(at)cleverelephant(dot)ca>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Pg18 Recursive Crash |
| Date: | 2024-12-18 01:02:03 |
| Message-ID: | 2543667.1734483723@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> I've pushed the patch now.
So I tried adapting my patch to not make a copy of the input slot,
and it didn't work: I was still getting assertion failures about
the slot not being a MinimalTupleSlot as expected. On investigation
it appears your patch did not fully adjust BuildTupleHashTableExt
for variable input-slot type. You need the attached as well.
I'm not sure why the existing regression tests didn't catch this.
But it may not be worth searching for a test case, because my patch
will be one ...
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| fix-grouping.patch | text/x-diff | 707 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andreas Karlsson | 2024-12-18 01:31:14 | Re: Add CASEFOLD() function. |
| Previous Message | Robert Pang | 2024-12-18 00:50:16 | Back-patch of: avoid multiple hard links to same WAL file after a crash |