| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove some useless casts to (void *) |
| Date: | 2023-02-07 07:09:57 |
| Message-ID: | 2542ac5a-5dc6-608a-f9f1-360e11652826@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03.02.23 00:59, Corey Huinker wrote:
> On Thu, Feb 2, 2023 at 5:22 PM Peter Eisentraut
> <peter(dot)eisentraut(at)enterprisedb(dot)com
> <mailto:peter(dot)eisentraut(at)enterprisedb(dot)com>> wrote:
>
> I have found that in some corners of the code some calls to standard C
> functions are decorated with casts to (void *) for no reason, and this
> code pattern then gets copied around. I have gone through and cleaned
> this up a bit, in the attached patches.
>
> The involved functions are: repalloc, memcpy, memset, memmove, memcmp,
> qsort, bsearch
>
> Also hash_search(), for which there was a historical reason (the
> argument used to be char *), but not anymore.
>
>
> +1
committed
> All code is example code.
I like that one!
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2023-02-07 07:11:06 | A bug in make_outerjoininfo |
| Previous Message | Kyotaro Horiguchi | 2023-02-07 07:07:03 | Re: Make mesage at end-of-recovery less scary. |