| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Florian Pflug <fgp(dot)phlo(dot)org(at)gmail(dot)com> |
| Cc: | Hannu Krosing <hannu(at)skype(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, Marko Kreen <markokr(at)gmail(dot)com>, Jan Wieck <JanWieck(at)Yahoo(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Skytools committed without hackers discussion/review |
| Date: | 2007-10-10 22:19:11 |
| Message-ID: | 25397.1192054751@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Florian Pflug <fgp(dot)phlo(dot)org(at)gmail(dot)com> writes:
> Tom Lane wrote:
>> I think txid_current_snapshot should read ActiveSnapshot. If the user wants
>> to get a beginning-of-xact rather than beginning-of-statement snapshot from
>> it, he should be required to call it in a serializable transaction.
> Hm... does txid require that the snapshot it uses a valid in the sense that
> its xmin follows OldestXmin? If not, we could keep the snapshot around for txid,
> but still update our published xmin - which seems to be the main reason we care
> about getting rid of old snapshots at all.
Why should we complicate the main code like that for txid? I have not
heard any argument why the function should be examining
SerializableSnapshot instead of the current transaction snapshot.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-10-10 22:39:58 | Re: [COMMITTERS] pgsql: Added the Skytools extended transaction ID module to contrib as |
| Previous Message | Neil Conway | 2007-10-10 21:48:22 | pgsql: Minor correction for full-text search limitations docs. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-10-10 22:39:58 | Re: [COMMITTERS] pgsql: Added the Skytools extended transaction ID module to contrib as |
| Previous Message | andy | 2007-10-10 21:57:39 | Re: full text search in 8.3 |