From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: keywords in pg_hba.conf are case-sensitive? |
Date: | 2012-02-02 16:33:30 |
Message-ID: | 25350.1328200410@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
[ adjusting thread title to have something to do with reality ]
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Excerpts from Robert Haas's message of jue feb 02 11:39:29 -0300 2012:
>> We have lots of things that are case-sensitive; I don't particularly
>> see why this one should be different.
> Err, postgresql.conf processing is case insensitive, which is the most
> closely related example. Are you saying we should make that case
> sensitive as well? What I'm saying is that I see no good reason for
> keyword comparison to be case sensitive here. We don't compare case on
> SQL keywords either.
One thing I'm concerned about is that there are places in pg_hba.conf
where a token might be either a keyword or a user/group/database name.
If you start recognizing keywords case-insensitively, you could break
files that used to work, ie what was meant to be a name will now be
read as a keyword. Admittedly, the odds of that are not very large, but
they're not zero either. Given the entire lack of complaints about this
from the field, I'm inclined to think it's better to leave well enough
alone. We could add a documentation note if you feel a need for that.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-02-02 17:18:26 | Re: spgist text_ops and LIKE |
Previous Message | Jeff Janes | 2012-02-02 16:32:28 | Re: Vacuum rate limit in KBps |