Peter opens a can of worms

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: Peter opens a can of worms
Date: 2000-01-14 01:32:51
Message-ID: 25314.947813571@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter E writes (in elog.h):

+ #ifndef __GNUC__
extern void elog(int lev, const char *fmt, ...);
+ #else
+ /* This extension allows gcc to check the format string for consistency with
+ the supplied arguments. */
+ extern void elog(int lev, const char *fmt, ...) __attribute__ ((format (printf
, 2, 3)));
+ #endif

Cool. Now who's going to fix the cartload of warnings this has
produced? I'm counting about 125 of them. They should be fixed,
on grounds of portability, but the main problem right now is that
it's difficult to see the *real* warnings because of all these
guys...

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Don Baccus 2000-01-14 01:43:39 Re: [HACKERS] [hackers]development suggestion needed
Previous Message Tom Lane 2000-01-14 01:23:24 Re: [HACKERS] [hackers]development suggestion needed