Re: Should we remove unused code?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Should we remove unused code?
Date: 2016-04-18 15:18:53
Message-ID: 25311.1460992733@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> writes:
> For instance there are two flags - HASH_SEGMENT and HASH_FFACTOR that
> are in fact never used (see attachment). I wonder whether we should
> keep code like this or not.

> What do you think?

The fact that make check-world doesn't run any code that uses some
feature isn't a great argument for removing it. Consider third-party
extensions, for starters.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2016-04-18 15:19:55 Re: Parser extensions (maybe for 10?)
Previous Message Andres Freund 2016-04-18 15:15:36 Re: Spinlocks and semaphores in 9.2 and 9.3