| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> | 
|---|---|
| To: | lars(at)greiz-reinsdorf(dot)de | 
| Cc: | pgsql-bugs(at)lists(dot)postgresql(dot)org | 
| Subject: | Re: BUG #18210: libpq: PQputCopyData sometimes fails in non-blocking mode over GSSAPI encrypted connection | 
| Date: | 2023-11-22 22:29:34 | 
| Message-ID: | 2524668.1700692174@sss.pgh.pa.us | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-bugs | 
I wrote:
> I wonder if we should drop the idea of returning a positive bytecount
> after a partial write, and just return the pqsecure_raw_write result,
> and not reset PqGSSSendConsumed until we write everything presented.
> In edge cases maybe that would result in some buffer bloat, but it
> doesn't seem worse than what happens when the very first
> pqsecure_raw_write returns EINTR.
Here's a patch that fixes it along those lines.  I like this better,
I think, not least because it removes the assumption that "interesting"
pqsecure_raw_write failures will recur on the next try.
Still need to look at syncing the backend with this.
regards, tom lane
| Attachment | Content-Type | Size | 
|---|---|---|
| 0003-alternative-gssapi-fix.patch | text/x-diff | 5.1 KB | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Frank Büttner | 2023-11-23 08:21:50 | Misconfiguration on SSL for download.postgresql.org ? | 
| Previous Message | Lars Kanis | 2023-11-22 20:21:47 | Re: BUG #18210: libpq: PQputCopyData sometimes fails in non-blocking mode over GSSAPI encrypted connection |