| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql: setlocale() on Windows doesn't work correctly if the locale name |
| Date: | 2011-04-20 13:38:27 |
| Message-ID: | 25219.1303306707@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp> writes:
> I see another issue for the behavior.
> For example, the following code in src/backend/utis/adt/pg_locale.c
> won't work as expected in case the current locale is Hong Kong, Macao or
> UAE because the last setlocale() in the code would fail. I can
> find such save & restore operations of locales in several places.
Well, if Windows' setlocale is too brain-dead to accept its own output,
there's nothing to be done about it except to file a bug with Microsoft.
There isn't anything in the POSIX API that would let us avoid using
setlocale with a previous result value to restore the previous setting.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2011-04-20 20:23:35 | pgsql: Fix PL/Python traceback for error in separate file |
| Previous Message | Hiroshi Inoue | 2011-04-20 13:16:38 | Re: Re: [COMMITTERS] pgsql: setlocale() on Windows doesn't work correctly if the locale name |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-04-20 13:49:08 | Re: database system identifier differs between the primary and standby |
| Previous Message | rajibdk | 2011-04-20 13:28:11 | database system identifier differs between the primary and standby |