Randomly placed definition of S_ISDIR() in psql/copy.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: Randomly placed definition of S_ISDIR() in psql/copy.c
Date: 2009-04-25 20:35:21
Message-ID: 25175.1240691721@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Why does psql/copy.c contain this?

#if defined(WIN32) && !defined(S_ISDIR)
#define __S_ISTYPE(mode, mask) (((mode) & S_IFMT) == (mask))
#define S_ISDIR(mode) __S_ISTYPE((mode), S_IFDIR)
#endif

Surely a better place for such a thing is src/include/port/win32.h
... where indeed there already is a definition of S_ISDIR().
So I think this is dead code as well as poor style. Any objection to
seeing what happens if we remove it?

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2009-04-26 00:39:07 Re: Randomly placed definition of S_ISDIR() in psql/copy.c
Previous Message Bruce Momjian 2009-04-25 15:53:57 Re: Copyright waiver from Helios (fix for non-BSD copyright)