| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: src/test/subscription/t/005_encoding.pl is broken |
| Date: | 2017-09-18 17:59:30 |
| Message-ID: | 25173.1505757570@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2017-09-18 11:50:06 -0400, Tom Lane wrote:
>> The reason seems to be that its method of waiting for replication
>> to happen is completely inapropos. It's watching for the master
>> to say that the slave has received all the WAL, but that does not
>> ensure that the logicalrep apply workers have caught up, does it?
> To my knowledge here's not really any difference between the two in
> logical replication. Received changes are immediately applied, there's
> no equivalent to a walreceiver queing up "logical wal" onto disk.
> So I'm not sure that theory holds.
Well, there's *something* wrong with this test's wait method.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2017-09-18 17:59:48 | Re: psql: new help related to variables are not too readable |
| Previous Message | Andres Freund | 2017-09-18 17:58:29 | Re: src/test/subscription/t/005_encoding.pl is broken |