Re: pgsql: Test conversion of NaN between float4 and float8.

From: Glyn Astill <glynastill(at)yahoo(dot)co(dot)uk>
To: <pgsql-committers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: pgsql: Test conversion of NaN between float4 and float8.
Date: 2018-05-03 10:05:09
Message-ID: 251274902.5877135.1525341909611@mail.yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Apologies Tom, I missed this; opossum is running one of its infrequent build runs now.

--------------------------------------------
On Sat, 21/4/18, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

Subject: pgsql: Test conversion of NaN between float4 and float8.
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Date: Saturday, 21 April, 2018, 0:55

Test conversion of NaN between float4 and
float8.

Results from buildfarm member opossum
suggest that this doesn't work
quite right on that platform. 
We've seen issues with NaN support on
MIPS/NetBSD before ... allegedly they
fixed this stuff back in 2010,
but maybe only for small values of
"fixed".

If, in fact, opossum fails this test
then I plan to revert it;
it's mainly for diagnostic purposes
rather than something we'd
necessarily keep long-term.  I
think that the failures in window.sql
could be worked around with some code
duplication, but I want to
verify my theory about the cause
first.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/55e0e458170c76c1a0074cd550a13ec47e38a3fa

Modified Files
--------------
src/test/regress/expected/float4-exp-three-digits.out
| 12 ++++++++++++
src/test/regress/expected/float4.out   
              | 12
++++++++++++
src/test/regress/sql/float4.sql 
               
    |  2 ++
3 files changed, 26 insertions(+)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2018-05-03 12:43:07 pgsql: Fix SPI error cleanup and memory leak
Previous Message Teodor Sigaev 2018-05-03 07:47:04 Re: pgsql: Indexes with INCLUDE columns and their support in B-tree