From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Dave Cramer <davecramer(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Request for comment on setting binary format output per session |
Date: | 2023-04-17 20:22:26 |
Message-ID: | 2510332.1681762946@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Apr 17, 2023 at 1:55 PM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
>> Maybe we should have a single new message type 'x' to indicate a
>> message for a protocol extension, and then have a sub-message-type? It
>> might make error handling better for unexpected messages.
> ...
> The point of this thought experiment is to help us estimate how
> careful we need to be.
I tend to agree with the proposition that we aren't going to add new
message types very often, as long as we're careful to make them general
purpose. Don't forget that adding a new message type isn't just a matter
of writing some spec text --- there has to be code backing it up. We
will never introduce thousands of new message types, or if we do,
somebody factored it wrong and put data into the type code.
The fact that we've gotten away without adding *any* new message types
for about twenty years suggests to me that the growth rate isn't such
that we need sub-message-types yet. I'd keep the structure the same
until such time as we can't choose a plausible code value for a new
message, and then maybe add the "x-and-subtype" convention Jeff suggests.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2023-04-17 20:22:30 | Re: pgsql: Further cleanup of autoconf output files for GSSAPI changes. |
Previous Message | Tom Lane | 2023-04-17 19:53:41 | Re: pgsql: Further cleanup of autoconf output files for GSSAPI changes. |