| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Euler Taveira de Oliveira <euler(at)timbira(dot)com> |
| Cc: | PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org>, Martin Pitt <martin(at)piware(dot)de> |
| Subject: | Re: stopping server does not remove external_pid_file |
| Date: | 2006-06-07 02:52:01 |
| Message-ID: | 25099.1149648721@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Euler Taveira de Oliveira <euler(at)timbira(dot)com> writes:
> Martin Pitt wrote:
>> I just played around with external_pid_file in 8.1.4. I noticed that
>> the file is created and filled properly, but it is not removed again
>> when the server is stopped.
>>
> Looking at the code I see this comment in
> src/backend/postmaster/postmaster.c
> /* Should we remove the pid file on postmaster exit? */
> IMHO, yes. It's not useful anymore.
[ shrug... ] If the postmaster crashes, it would certainly fail to
remove the pidfile. So I'd argue that your unnamed external script
that is expecting the pidfile to go away needs work: if it's not
verifying the PID given in the file, it's broken.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2006-06-07 03:25:43 | Re: stopping server does not remove external_pid_file |
| Previous Message | Euler Taveira de Oliveira | 2006-06-07 01:46:16 | Re: stopping server does not remove external_pid_file |