| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Andreas Karlsson <andreas(at)proxel(dot)se>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: \h tab-completion |
| Date: | 2017-03-13 14:56:31 |
| Message-ID: | 249ad85c-3955-d19b-305f-1b4c5ad1226c@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Andreas,
On 3/1/17 8:47 AM, Peter Eisentraut wrote:
> On 2/3/17 07:12, Andreas Karlsson wrote:
>> On 01/25/2017 07:13 AM, Michael Paquier wrote:
>>> What I think you should do is making the code path of
>>> \\h smarter with some exceptions by using TailMatchesCS2() for ALTER.
>>> There is as well the case of DROP commands that should be treated by
>>> the way.
>>
>> Yes, I think that is correct approach. I have attached a patch where I
>> add completion for \h ALTER and \h DROP.
>
> Instead of creating another copy of list_ALTER, let's use the
> words_after_create list and write a version of
> create_command_generator/drop_command_generator.
Do you know when you will have a new patch available for review that
incorporates Peter's request?
Thanks,
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2017-03-13 14:58:03 | Re: [GSOC 17] Eliminate O(N^2) scaling from rw-conflict tracking in serializable transactions |
| Previous Message | David Steele | 2017-03-13 14:42:05 | Re: IF (NOT) EXISTS in psql-completion |