| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | ilmari(at)ilmari(dot)org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) |
| Cc: | "Tels" <nospam-pg-abuse(at)bloodgate(dot)com>, "Victor Wagner" <vitus(at)wagner(dot)pp(dot)ru>, "pgsql-hackers" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Non-portable shell code in pg_upgrade tap tests |
| Date: | 2018-07-21 18:04:19 |
| Message-ID: | 24992.1532196259@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
ilmari(at)ilmari(dot)org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>> Hmm. Yeah, probably. I don't think this script is meant to be run with
>> arbitrary values of PGDATA, but most of the other uses are quoted, so
>> for consistency's sake this should be too.
> Attached is a patch fixing this. I checked the rest of the script, and
> this seems to be the only place lacking quoting.
Done already, but thanks.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Charles Cui | 2018-07-21 19:00:48 | Re: project updates |
| Previous Message | Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= | 2018-07-21 16:47:00 | Re: Non-portable shell code in pg_upgrade tap tests |