| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: retire MemoryContextResetAndDeleteChildren backwards compatibility macro |
| Date: | 2023-11-14 17:10:41 |
| Message-ID: | 2498233.1699981841@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
>> It might be worth introducing pg_attribute_deprecated() in c.h. I'm not
>> too worried about this particular macro, but it seems handy in general.
> Huh, this was brought up before [0].
> [0] https://postgr.es/m/20200825183002.fkvzxtneijsdgrfv%40alap3.anarazel.de
FWIW, I think it's fine to just nuke MemoryContextResetAndDeleteChildren.
We ask extension authors to deal with much more significant API changes
than that in every release, and versions where the updated code wouldn't
work are long gone. And, as you say, the existence of that separate from
MemoryContextReset creates confusion, which has nonzero cost in itself.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kanmani Thamizhanban | 2023-11-14 17:13:36 | Issue with launching PGAdmin 4 on Mac OC |
| Previous Message | Nathan Bossart | 2023-11-14 17:04:51 | Re: retire MemoryContextResetAndDeleteChildren backwards compatibility macro |