| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | John Naylor <jcnaylor(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP: a way forward on bootstrap data |
| Date: | 2018-04-05 20:52:13 |
| Message-ID: | 24962.1522961533@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
John Naylor <jcnaylor(at)gmail(dot)com> writes:
> Looking at convert_oid2name.patch again, I see this:
> + elsif ($catname eq 'pg_am')
> + {
> + $values{aggfnoid} = lookup_procname($values{aggfnoid});
> + }
> aggfnoid is in pg_aggregate, and pg_am already had a regproc lookup.
> Do you remember the intent here?
Ugh, copy-and-pasteo. I intended to have it lookup pg_am.amhandler, but
must have missed changing the field name after copying code from the
pg_aggregate stanza. Seems to have been unnecessary anyway, since all the
entries in the column are already symbolic.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-04-05 20:55:58 | Re: file cloning in pg_upgrade and CREATE DATABASE |
| Previous Message | Joshua D. Drake | 2018-04-05 20:51:41 | Re: Online enabling of checksums |