| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: pg_restore ignore error patch |
| Date: | 2004-04-20 01:41:38 |
| Message-ID: | 2496.1082425298@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> I looked over the patch and it seems to continue on pg_restore errors by
> default. That isn't good. By default, any error should make it exit
> loudly.
I'm not sure of that. pg_dump is really designed and tested for the
case of text dump to a psql script, and if there is an error in the psql
script, psql will print it out and continue. In the cases I have seen
where pg_restore operates differently from that paradigm, the pg_restore
behavior of curling up and dying has *never* been the right thing.
I haven't looked at the details of Fabien's patch, but I'm in agreement
with the overall goal.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2004-04-20 01:51:00 | Re: pg_restore ignore error patch |
| Previous Message | Bruce Momjian | 2004-04-20 00:58:49 | Re: EXECUTE command tag returns actual command |