| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump -j against standbys |
| Date: | 2016-05-25 14:21:30 |
| Message-ID: | 24912.1464186090@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Also, why didn't you keep using ExecuteSqlQueryForSingleRow()?
> The reason I did that is that ExecuteSqlQueryForSingleRow() is a static
> method in pg_dump.c. I was planning to go back and review that, and
> consider moving it, but I forgot it :S
> I think the clean thing is probably to use that one, and also move it over
> to not be a static method in pg_dump.c, but instead sit next to
> ExecuteSqlQuery in pg_backup_db.c. Do you agree that's reasonable, and
> something that's OK to backpatch?
No objection here, since it wouldn't be exposed outside pg_dump in any
case.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vladimir Borodin | 2016-05-25 14:33:52 | 9.4 -> 9.5 regression with queries through pgbouncer on RHEL 6 |
| Previous Message | Tom Lane | 2016-05-25 14:14:39 | Re: Does people favor to have matrix data type? |