| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: aix: No need to use mkldexport when we want to export all symbol |
| Date: | 2022-09-14 02:45:46 |
| Message-ID: | 2490844.1663123546@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> So we could work around the xlc 12.1 issue with something like the attached
> patch. It passes at some of the tests, with both 32 and 64bit xlc 12.1, will
> have to wait a while to see more
Shouldn't that be more like
+ if test "$pgac_cv_prog_CC_cflags__qvisibility_hidden" != "yes"; then
+ CFLAGS_SL_MODULE='$CFLAGS_SL_MODULE -Wl,-b,expfull'
+ fi
to avoid losing whatever we found out before that?
> I think it'd be considerably better to just not support xlc < 13.1 though.
A three-line patch doesn't seem like an unreasonable thing to carry,
at least till these systems go out of support. We've jumped through
much higher hoops in the past to support niche platforms.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-09-14 03:18:05 | pgsql: Simplify handling of compression level with compression specific |
| Previous Message | Andres Freund | 2022-09-14 02:39:32 | Re: pgsql: aix: No need to use mkldexport when we want to export all symbol |