| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Zeugswetter Andreas SB SD <ZeugswetterA(at)spardat(dot)at>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: elog() patch |
| Date: | 2002-03-04 03:26:45 |
| Message-ID: | 24867.1015212405@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> However, with DEBUG symbol gone, or at least gone after 7.3, I don't see
> a big need to add PG_ to the beginning of every elog() symbol. Can I
> get some votes on that? DEBUG was our big culprit of conflict with
> other interfaces, specifically Perl.
Wrong: ERROR is a problem too. And if you think that INFO or WARNING
or PANIC will not create new problems, you are a hopeless optimist.
We are already forcing renamings of a lot of elog symbols (eg, NOTICE
and DEBUG), so we may as well go the extra step and actually solve the
problem, rather than continue to ignore it.
BTW, I'd go with PGERROR etc, not PG_ERROR, just to save typing.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2002-03-04 03:28:55 | Re: elog() patch |
| Previous Message | Bruce Momjian | 2002-03-04 03:24:24 | Re: elog() patch |