| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, John Naylor <jcnaylor(at)gmail(dot)com>, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>, Andreas Karlsson <andreas(at)proxel(dot)se>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, David Fetter <david(at)fetter(dot)org> |
| Subject: | Re: unused_oids script is broken with bsd sed |
| Date: | 2018-05-04 02:42:41 |
| Message-ID: | 24838.1525401761@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 5/3/18 15:37, Tom Lane wrote:
>> I took a quick look into this. It's very easy to do so far as the Perl
>> code is concerned:
> I think in order to introduce warts like that, we have to have really
> great savings. I haven't seen any actual analysis what the current
> problem is, other than one person expression a suspicion.
Well, the work's already done, and personally I think the code is
cleaner after 9bf28f96c and bad51a49a regardless of whether there's any
performance benefit. You could call 1f1cd9b5d a wart if you wanted.
But we've done largely the same thing to pgindent, for one, in the past
year or so, and I find that to be a usability improvement, independently
of whether there's any build performance win. My editor gets cranky
when files change under it for no reason.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2018-05-04 03:03:07 | Re: ignore_system_indexes affects DROP SCHEMA ... CASCADE reported number of objects dropped |
| Previous Message | Tom Lane | 2018-05-04 02:31:44 | Re: ignore_system_indexes affects DROP SCHEMA ... CASCADE reported number of objects dropped |