| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Remove win32ver.rc from version_stamp.pl |
| Date: | 2020-03-10 15:07:00 |
| Message-ID: | 24807.1583852820@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
I wrote:
> I'd suggest reverting the change in how PG_VERSION_NUM is computed
> in configure.in --- that was certainly not necessary to the patch,
> and evidently you're falling foul of some weird behavior around
> nesting double-quotes and backquotes.
Actually, you can just get rid of the nesting, because there's no
need to be picky about what white-space gets fed to awk. The
attached seems to be enough to fix it (tested on gaur).
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| fix-version-num.patch | text/x-diff | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-03-10 15:48:48 | pgsql: Split out CreateCast into src/backend/catalog/pg_cast.c |
| Previous Message | Tom Lane | 2020-03-10 14:49:05 | Re: pgsql: Remove win32ver.rc from version_stamp.pl |